Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753772Ab0BSQ72 (ORCPT ); Fri, 19 Feb 2010 11:59:28 -0500 Received: from terminus.zytor.com ([198.137.202.10]:37369 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090Ab0BSQ70 (ORCPT ); Fri, 19 Feb 2010 11:59:26 -0500 Message-ID: <4B7EC20C.30607@zytor.com> Date: Fri, 19 Feb 2010 08:53:32 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Borislav Petkov CC: Michal Marek , linux-kbuild , Peter Zijlstra , Andrew Morton , Wu Fengguang , LKML , Jamie Lokier , Roland Dreier , Al Viro , "linux-fsdevel@vger.kernel.org" , Ingo Molnar , Brian Gerst Subject: Re: [PATCH] x86: Add optimized popcnt variants References: <4B758FC0.1020600@zytor.com> <20100212174751.GD3114@aftab> <4B75A66A.70005@zytor.com> <4B7BF5D6.3030701@suse.cz> <20100217172040.GC13429@aftab> <4B7C27D8.9050408@suse.cz> <4B7C29C1.10906@suse.cz> <20100218061923.GA1594@liondog.tnic> <20100219142205.GA32533@aftab> <4B7EB6EF.9010405@zytor.com> <20100219164512.GA492@aftab> In-Reply-To: <20100219164512.GA492@aftab> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 25 On 02/19/2010 08:45 AM, Borislav Petkov wrote: >> >> You're still not inlining these. They should be: there is absolutely no >> reason for code size to not inline them anymore. > > Isn't better to have only those 4 locations for apply_alternatives to > patch wrt to popcnt instead of sprinkling alternatives sections around > the kernel in every callsite of hweight and its users? Or is the aim to > optimize even that "call __arch_hweightXX" away? > That's the idea, yes. We use inline alternatives in quite a few other places. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/