Date: Fri, 19 Feb 2010 23:11:00 +0300
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Richard =?utf-8?Q?R=C3=B6jfors?= 
	<richard.rojfors.ext@mocean-labs.com>,
       Pierre Ossman <pierre@ossman.eu>, Ben Dooks <ben@simtec.co.uk>,
       linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] sdhci: Implement CAP_CLOCK_BASE_BROKEN quirk
Message-ID: <20100219201100.GA17881@oksana.dev.rtsoft.ru>
Reply-To: avorontsov@ru.mvista.com
References: <20100219194827.GA16636@oksana.dev.rtsoft.ru>
 <4B7EECB2.9090406@csr.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4B7EECB2.9090406@csr.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1375
Lines: 37

On Fri, Feb 19, 2010 at 07:55:30PM +0000, David Vrabel wrote:
> Anton Vorontsov wrote:
> > Some hosts (e.g. as found in CNS3xxx SOCs) report wrong value in
> > CLOCK_BASE capability field, and currently there is no way to
> > force the SDHCI core to use the platform-provided base clock value.
> 
> I don't think this needs a new quirk. Change the sdhci driver to check
> if the platform provides a value before reading the standard register.

Well, Pierre once said that by default we should conform to the
SDHCI spec, and any diviations from the spec should be handled by
the quirks:

http://linux.derkeiler.com/Mailing-Lists/Kernel/2009-02/msg03385.html

Spec clearly states that base clock == 0 is the case when we should
fall back to the platform-provided clocks.

So, for controllers that conform to the spec, following might be
true:

- Platform provides its own (alternate) clock, but
- SDHCI block choose not to use it, and doesn't clear bits in the
  capability register
- Then the driver should not use the platform provided clock.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/