Date: Fri, 19 Feb 2010 13:45:35 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
       Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
       Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
       Kay Sievers <kay.sievers@vrfy.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
       Michael Kerrisk <mtk.manpages@gmail.com>,
       Christoph Hellwig <hch@infradead.org>,
       Alexander Gordeev <lasaine@lvk.cs.msu.su>
Subject: Re: [PATCH 5/8] ldisc n_tty: add new method n_tty_inherit_ops()
Message-Id: <20100219134535.51d47c25.akpm@linux-foundation.org>
In-Reply-To: <1266313885-1195-6-git-send-email-giometti@linux.it>
References: <1266313885-1195-1-git-send-email-giometti@linux.it>
	<1266313885-1195-2-git-send-email-giometti@linux.it>
	<1266313885-1195-3-git-send-email-giometti@linux.it>
	<1266313885-1195-4-git-send-email-giometti@linux.it>
	<1266313885-1195-5-git-send-email-giometti@linux.it>
	<1266313885-1195-6-git-send-email-giometti@linux.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 738
Lines: 24

On Tue, 16 Feb 2010 10:51:22 +0100
Rodolfo Giometti <giometti@linux.it> wrote:

>  };
> +
> +void n_tty_inherit_ops(struct tty_ldisc_ops *ops)
> +{
> +	*ops = tty_ldisc_N_TTY;
> +	ops->owner = NULL;
> +	ops->refcount = ops->flags = 0;
> +}
> +EXPORT_SYMBOL_GPL(n_tty_inherit_ops);

Most (nearly all) functions in n_tty.c have been documented in
kerneldoc form.  Let's continue that please.

n_tty_inherit_ops() is of course pretty simple, but OTOH it's a global,
export-to-modules interface.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/