Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221Ab0BUOl1 (ORCPT ); Sun, 21 Feb 2010 09:41:27 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]:48038 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702Ab0BUOl0 convert rfc822-to-8bit (ORCPT ); Sun, 21 Feb 2010 09:41:26 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=dxtCbj6+zk8Y5msHdXLH12XZgHdNe+lHbC4mGyuIMZ8Cqeh8zhygjMmGzPBna8qWq/ mRYlEfyGtsPNY/RQTgQlB9MCg+bJFNiujo+UwM9k9pfB59CNctem4HOz7F174yyn9tyC eEsgA6SxXrPlrs5v2uOZkehDpxVal9eU7RLOE= MIME-Version: 1.0 In-Reply-To: <20100221142813.GB21281@core2> References: <20100221142303.GA3004@darkstar> <20100221142813.GB21281@core2> Date: Sun, 21 Feb 2010 22:33:43 +0800 Message-ID: Subject: Re: [PATCH -mm 03/17] sysctl extern cleanup - binfmts From: Dave Young To: Alexey Dobriyan Cc: Ingo Molnar , Andrew Morton , Peter Zijlstra , James Morris , "Eric W. Biederman" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 33 On Sun, Feb 21, 2010 at 10:28 PM, Alexey Dobriyan wrote: > On Sun, Feb 21, 2010 at 10:23:03PM +0800, Dave Young wrote: >> --- linux-2.6.32.orig/include/linux/binfmts.h >> +++ linux-2.6.32/include/linux/binfmts.h >> @@ -20,6 +20,11 @@ struct pt_regs; >>  #ifdef __KERNEL__ >>  #include >> >> +/* for sysctl */ > > This comment is neither accurate nor needed. :^) Thanks, sounds good, but the there's no other file use the three vars. > > In fact master sysctl table always was a big mess, so slight mess > caused by extern declarations is fine. > >> +extern int core_uses_pid; >> +extern char *core_pattern; >> +extern unsigned int core_pipe_limit; > -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/