Date: Sun, 21 Feb 2010 08:58:10 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>, Ingo Molnar <mingo@elte.hu>,
       Lai Jiangshan <laijs@cn.fujitsu.com>,
       Vegard Nossum <vegard.nossum@gmail.com>,
       Josh Triplett <josh@joshtriplett.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       James Morris <jmorris@namei.org>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 09/17] sysctl extern cleanup - rcu
Message-ID: <20100221165810.GB11015@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <20100221142412.GA3011@darkstar>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100221142412.GA3011@darkstar>
User-Agent: Mutt/1.5.15+20070412 (2007-04-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1732
Lines: 45

On Sun, Feb 21, 2010 at 10:24:12PM +0800, Dave Young wrote:
> Extern declarations in sysctl.c should be move to their own head file,
> and then include them in relavant .c files.
> 
> Move rcutorture_runnable extern declaration to linux/rcupdate.h

Reviewed-by: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> Acked-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  include/linux/rcupdate.h |    4 ++++
>  kernel/sysctl.c          |    3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.32.orig/include/linux/rcupdate.h	2010-02-21 09:35:58.013190490 +0800
> +++ linux-2.6.32/include/linux/rcupdate.h	2010-02-21 10:03:53.296358225 +0800
> @@ -41,6 +41,10 @@
>  #include <linux/lockdep.h>
>  #include <linux/completion.h>
> 
> +#ifdef CONFIG_RCU_TORTURE_TEST
> +extern int rcutorture_runnable; /* for sysctl */
> +#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
> +
>  /**
>   * struct rcu_head - callback structure for use with RCU
>   * @next: next update requests in a list
> --- linux-2.6.32.orig/kernel/sysctl.c	2010-02-21 09:58:40.029722800 +0800
> +++ linux-2.6.32/kernel/sysctl.c	2010-02-21 10:01:30.257204779 +0800
> @@ -75,9 +75,6 @@
> 
>  /* External variables not in a header file. */
>  extern int max_threads;
> -#ifdef CONFIG_RCU_TORTURE_TEST
> -extern int rcutorture_runnable;
> -#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
>  #ifdef CONFIG_BLOCK
>  extern int blk_iopoll_enabled;
>  #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/