Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555Ab0BVOU3 (ORCPT ); Mon, 22 Feb 2010 09:20:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395Ab0BVOUW (ORCPT ); Mon, 22 Feb 2010 09:20:22 -0500 Message-ID: <4B829347.1090106@redhat.com> Date: Mon, 22 Feb 2010 09:23:03 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc11 Thunderbird/3.0.1 MIME-Version: 1.0 To: Frederic Weisbecker CC: Mike Frysinger , Heiko Carstens , Ingo Molnar , LKML , Martin Schwidefsky , "David S . Miller" , Paul Mundt , Steven Rostedt Subject: Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic References: <1266491616-6270-1-git-send-regression-fweisbec@gmail.com> <1266491616-6270-3-git-send-regression-fweisbec@gmail.com> <8bd0f97a1002180318g6ce70480x571d7d332239d68b@mail.gmail.com> <20100218120944.GA2406@osiris.boeblingen.de.ibm.com> <8bd0f97a1002180412x6cc4f280u5444f013c6e3b670@mail.gmail.com> <20100218123453.GA5136@nowhere> <20100218132521.GB2406@osiris.boeblingen.de.ibm.com> <8bd0f97a1002180601i60c5eaa4p7639091c5b617702@mail.gmail.com> <20100218145055.GB855@nowhere> <4B7D68AA.8060105@redhat.com> <20100222012735.GA8791@nowhere> In-Reply-To: <20100222012735.GA8791@nowhere> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2444 Lines: 79 Frederic Weisbecker wrote: > On Thu, Feb 18, 2010 at 11:19:54AM -0500, Masami Hiramatsu wrote: >>> For now it is stored is asm/ptrace.h, but that might be split in >>> the future, especially as ptrace has initially nothing related to >>> that. A documentation that deals with filenames or API enumerations >>> tend to be incidentally async with API evolutions. >> >> yeah, now those APIs depend on pt_regs, so I put it in ptrace.h. >> >> Thank you, > > > Are you guys fine with the following patch or should I bring > more details somewhere? I'm fine with it :-) Acked-by: Masami Hiramatsu > > Thanks. > > --- > commit d3643132cfeac24ee20d2b6cd8cb06d73e6a6da9 > Author: Heiko Carstens > Date: Thu Feb 18 14:25:21 2010 +0100 > > tracing/kprobes: Add short documentation for HAVE_REGS_AND_STACK_ACCESS_API > > So that arch developers know how to implement it without the > need to dig into changelogs. > > Reported-by: Mike Frysinger > Signed-off-by: Heiko Carstens > Cc: Masami Hiramatsu > Cc: Martin Schwidefsky > Cc: "David S . Miller" > Cc: Paul Mundt > Cc: Steven Rostedt > LKML-Reference: <20100218132521.GB2406@osiris.boeblingen.de.ibm.com> > [added reference to ptrace.h in the config help] > Signed-off-by: Frederic Weisbecker > > diff --git a/arch/Kconfig b/arch/Kconfig > index 04e3aa7..50877ef 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -123,6 +123,11 @@ config USE_GENERIC_SMP_HELPERS > > config HAVE_REGS_AND_STACK_ACCESS_API > bool > + help > + This symbol should be selected by an architecure if it supports > + the API needed to access registers and stack entries from pt_regs, > + declared in asm/ptrace.h > + For example the kprobes-based event tracer needs this API. > > config HAVE_CLK > bool > > -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/