Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962Ab0BVQMl (ORCPT ); Mon, 22 Feb 2010 11:12:41 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:55647 "EHLO mail-ew0-f228.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753677Ab0BVQMj convert rfc822-to-8bit (ORCPT ); Mon, 22 Feb 2010 11:12:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=IuxQKWZV1aAta1PifNP4LP57pDj1F3/rBDEvpFFwJqeOdO17hb1WR3gTc+ZTs5P64c /GkhGUq08JrmwDeYtFhHz5RvMqYEGZ9930ZYHkUvHFNrzaaMlpr3Fqd3o0+hEU8Oqv5X tUvlkiF0jjjfRiuSlLu/x+syLK9M8AL2OSW9I= MIME-Version: 1.0 In-Reply-To: References: <520f0cf11002220311l2a0caa83lf3ae2817b78501b6@mail.gmail.com> <520f0cf11002220423u64daf89dxa6a4249522adabee@mail.gmail.com> Date: Mon, 22 Feb 2010 17:12:36 +0100 X-Google-Sender-Auth: f568d40090c18108 Message-ID: <520f0cf11002220812w108a8143rdbeea663a8c702f5@mail.gmail.com> Subject: Re: [ANNOUNCE] 2.6.33-rc8-rt1 From: John Kacur To: Thomas Gleixner Cc: LKML , rt-users , Ingo Molnar , Steven Rostedt , Peter Zijlstra , Carsten Emde , Clark Williams , Frank Rowand , Robin Gareus , Gregory Haskins , Philippe Reynes , Fernando Lopez-Lezcano , Will Schmidt , Darren Hart , Jan Blunck , Sven-Thorsten Dietrich , Jon Masters , Mark Knecht , Nick Piggin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8894 Lines: 197 On Mon, Feb 22, 2010 at 4:53 PM, John Kacur wrote: > > > On Mon, 22 Feb 2010, Thomas Gleixner wrote: > >> On Mon, 22 Feb 2010, John Kacur wrote: >> > That patch fixes the symptom I reported, but unfortunately, I still >> > can't log-in to my laptop without the machine freezing. >> > Not sure why, investigating. >> >> Found it, at least it make my mouse/keyboard work again and fixes the >> weird double character problem on VT login. >> >> Thanks, >> >> ? ? ? tglx >> ---- >> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c >> index 25642d1..1efad98 100644 >> --- a/kernel/irq/manage.c >> +++ b/kernel/irq/manage.c >> @@ -563,15 +563,20 @@ irq_wait_for_interrupt(struct irq_desc *desc, struct irqaction *action) >> ? * handler finished. unmask if the interrupt has not been disabled and >> ? * is marked MASKED. >> ? */ >> -static void irq_finalize_oneshot(unsigned int irq, struct irq_desc *desc) >> +static void irq_finalize_oneshot(unsigned int irq, struct irq_desc *desc, >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct irqaction *action) >> ?{ >> ? ? ? chip_bus_lock(irq, desc); >> +#ifndef CONFIG_PREEMPT_RT >> ? ? ? raw_spin_lock_irq(&desc->lock); >> ? ? ? if (!(desc->status & IRQ_DISABLED) && (desc->status & IRQ_MASKED)) { >> ? ? ? ? ? ? ? desc->status &= ~IRQ_MASKED; >> ? ? ? ? ? ? ? desc->chip->unmask(irq); >> ? ? ? } >> ? ? ? raw_spin_unlock_irq(&desc->lock); >> +#else >> + ? ? preempt_hardirq_thread_done(desc, action); >> +#endif >> ? ? ? chip_bus_sync_unlock(irq, desc); >> ?} >> >> @@ -645,7 +650,7 @@ static int irq_thread(void *data) >> ? ? ? ? ? ? ? ? ? ? ? action->thread_fn(action->irq, action->dev_id); >> >> ? ? ? ? ? ? ? ? ? ? ? if (oneshot) >> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? irq_finalize_oneshot(action->irq, desc); >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? irq_finalize_oneshot(action->irq, desc, action); >> ? ? ? ? ? ? ? } >> >> ? ? ? ? ? ? ? wake = atomic_dec_and_test(&desc->threads_active); >> > > > Thanks Thomas > > The fix seems to work for me. > I've got some other issues, but for now I'm going to assume they are the > same acpi problems I have reported to lkml for the "vanilla" -rc8 > Sorry, spoke to soon, graphical login still freezing. I did nohz=off and nmi_watchdog=2 as you told me in the irc session, and got a nice oops, here it is. ------------[ cut here ]------------ Kernel BUG at ffffffff81045d73 [verbose debug info unavailable] invalid opcode: 0000 [#1] PREEMPT SMP last sysfs file: /sys/class/power_supply/BAT0/energy_full CPU 0 Pid: 3467, comm: firefox-bin Tainted: G D 2.6.33-rc8-rt1-debug #2 2241B4 8/2241B48 RIP: 0010:[] [] do_exit+0x776/0x784 RSP: 0018:ffff88002be06e28 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000000002 RSI: 0000000000000003 RDI: ffff880115638000 RBP: ffff88002be06e98 R08: 0000000000000002 R09: 0000000000000001 R10: 0000000000000002 R11: 0000000000000046 R12: ffff88002be06e48 R13: ffff8801157fd200 R14: ffff88011546d080 R15: ffff8801157fd4c0 FS: 0000000000000000(0000) GS:ffff88002be00000(0000) knlGS:0000000000000000 CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b CR2: 00000034e64a7ce0 CR3: 0000000139bd3000 CR4: 00000000000006f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process firefox-bin (pid: 3467, threadinfo ffff880115638000, task ffff8801157fd2 00) Stack: 0000000081602f00 ffffffff8135cf95 ffff8801157fd4c0 ffff8801157fd1f0 <0> ffff88002be06e48 ffff88002be06e48 ffff88002bfcbb20 0000000000000001 <0> 0000000000000007 ffffffff811aca40 0000000000000046 ffff88002be06f58 Call Trace: [] ? _raw_spin_unlock_irqrestore+0x63/0x68 [] ? delay_tsc+0x6/0xc6 [] die_nmi+0xef/0xf8 [] nmi_watchdog_tick+0x159/0x1d6 [] do_nmi+0xc2/0x28a [] nmi+0x1a/0x2c [] ? delay_tsc+0x6/0xc6 <> [] __delay+0xa/0xc [] do_raw_spin_lock+0xde/0x146 [] _raw_spin_lock_irqsave+0x67/0x7f [] ? rcu_sched_qs+0x70/0x16c [] rcu_sched_qs+0x70/0x16c [] __schedule+0x32/0x923 [] ? restore_args+0x0/0x30 [] preempt_schedule+0x55/0x78 [] _raw_spin_unlock_irqrestore+0x63/0x68 [] rt_spin_lock_slowlock+0x2ad/0x2e0 [] ? rt_spin_lock_slowlock+0x0/0x2e0 [] rt_spin_lock_fastlock+0x56/0x5b [] rt_spin_lock+0x1f/0x42 [] __d_lookup+0xc5/0x189 [] ? __d_lookup+0x0/0x189 [] do_lookup+0x53/0x187 [] link_path_walk+0x2ca/0x699 [] path_walk+0x6d/0xeb [] do_path_lookup+0x2a/0x8a [] user_path_at+0x52/0x8c [] ? trace_hardirqs_on+0xd/0xf [] ? rt_spin_lock_slowunlock+0x4e/0x79 [] ? mntput_no_expire+0x24/0xf8 [] vfs_fstatat+0x35/0x62 [] vfs_lstat+0x19/0x1b [] sys32_lstat64+0x1a/0x34 [] ? path_put+0x1d/0x22 [] ? audit_syscall_entry+0x114/0x140 [] sysenter_dispatch+0x7/0x2c [] ? trace_hardirqs_on_thunk+0x3a/0x3f Code: bd 98 15 00 00 48 85 ff 74 05 e8 03 54 0b 00 bf 01 00 00 00 e8 b4 a2 31 00 e8 d2 85 05 00 49 c7 45 00 80 00 00 00 e8 58 50 31 00 <0f> 0b eb fe bb fe ff ff ff e9 1d ff ff ff 55 48 89 e5 41 56 41 RIP [] do_exit+0x776/0x784 RSP ---[ end trace 6f724503db632ce1 ]--- Fixing recursive fault but reboot is needed! BUG: NMI Watchdog detected LOCKUP on CPU1, ip ffffffff811aca7e, registers: CPU 1 Pid: 0, comm: swapper Tainted: G D 2.6.33-rc8-rt1-debug #2 2241B48/2241B 48 RIP: 0010:[] [] delay_tsc+0x44/0xc6 RSP: 0018:ffff88002c003d28 EFLAGS: 00000002 RAX: 00000000e46481d9 RBX: 00000000e4648146 RCX: 000000000000ab00 RDX: 00000000000000c5 RSI: ffffffff815527c6 RDI: 0000000000000001 RBP: ffff88002c003d58 R08: 0000000000000002 R09: 0000000000000001 R10: ffffffff8175bc00 R11: 0000000000000046 R12: 0000000000000001 R13: 00000000e46481d9 R14: 0000000000000001 R15: ffff88013bbcffd8 FS: 0000000000000000(0000) GS:ffff88002c000000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 0000000000f05fb0 CR3: 000000012c4c8000 CR4: 00000000000006e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process swapper (pid: 0, threadinfo ffff88013bbce000, task ffff88013bbd07c0) Stack: ffff88013bbd07c0 000000000d0fcb31 ffffffff8175c080 0000000000000001 <0> ffff88013bbd07c0 ffff88013bbd0ce8 ffff88002c003d68 ffffffff811ac9d5 <0> ffff88002c003da8 ffffffff811b0d50 00000000a6773048 ffffffff8175c098 Call Trace: [] __delay+0xa/0xc [] do_raw_spin_lock+0xde/0x146 [] ? tick_sched_timer+0x0/0x9d [] _raw_spin_lock_irqsave+0x67/0x7f [] ? rcu_print_task_stall+0x45/0xb4 [] rcu_print_task_stall+0x45/0xb4 [] ? tick_sched_timer+0x0/0x9d [] __rcu_pending+0x15b/0x2d3 [] ? tick_sched_timer+0x0/0x9d [] rcu_check_callbacks+0x6f/0x17a [] ? tick_sched_timer+0x0/0x9d [] update_process_times+0x3e/0x54 [] tick_sched_timer+0x73/0x9d [] __run_hrtimer+0xc9/0x13a [] hrtimer_interrupt+0xe0/0x1de [] smp_apic_timer_interrupt+0x81/0x94 [] apic_timer_interrupt+0x13/0x20 [] ? __atomic_notifier_call_chain+0x0/0x94 [] ? poll_idle+0x16/0x5f [] ? poll_idle+0x24/0x5f [] ? poll_idle+0x16/0x5f [] ? __atomic_notifier_call_chain+0x0/0x94 [] cpuidle_idle_call+0xa0/0x111 [] cpu_idle+0xa4/0x107 [] start_secondary+0x18f/0x194 Code: e8 bd 35 1b 00 e8 87 54 00 00 41 89 c6 66 66 90 0f ae e8 0f 31 89 c3 65 4c 8b 3c 25 48 95 00 00 66 66 90 0f ae e8 0f 31 41 89 c5 <4c> 89 e8 48 29 d8 4c 39 e0 73 49 bf 01 00 00 00 e8 04 35 1b 00 ---[ end trace 6f724503db632ce2 ]--- Kernel panic - not syncing: Aiee, killing interrupt handler! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/