Date: Mon, 22 Feb 2010 08:43:39 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
To: Cong Wang <amwang@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       "Luis R. Rodriguez" <lrodriguez@atheros.com>,
       Sam Ravnborg <sam@ravnborg.org>,
       Vegard Nossum <vegard.nossum@gmail.com>,
       Uwe =?UTF-8?B?S2xlaW5lLUvDg8K2bmln?= 
	<u.kleine-koenig@pengutronix.de>,
       "Robert P. J. Day" <rpjday@crashcourse.ca>,
       Arnd Bergmann <arnd@arndb.de>, Arjan van de Ven <arjan@linux.intel.com>,
       Hui Zhu <teawater@gmail.com>,
       Ozan =?UTF-8?B?w4NhZ2xheWFu?= <ozan@pardus.org.tr>,
       Matthew Wilcox <willy@linux.intel.com>,
       Steven Rostedt <rostedt@goodmis.org>, Li Hong <lihong.hi@gmail.com>,
       Ingo Molnar <mingo@elte.hu>, Ralf Baechle <ralf@linux-mips.org>,
       Matt Fleming <matt@console-pimps.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: improve checkstack
Message-ID: <20100222084339.1367cfe6@nehalam>
In-Reply-To: <4B7F90AA.8050306@redhat.com>
References: <20100219175217.385580142@vyatta.com>
	<20100219175429.611463369@vyatta.com>
	<4B7F5128.70501@redhat.com>
	<20100219222554.17d4bae6@nehalam>
	<4B7F90AA.8050306@redhat.com>
Organization: Vyatta
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1244
Lines: 35

On Sat, 20 Feb 2010 15:35:06 +0800
Cong Wang <amwang@redhat.com> wrote:

> Stephen Hemminger wrote:
> > Turn on strict checking, and get rid of annoying use of prototype.
> > Fix syntax error in declaration
> > 
> > Use efficient sort algorithm by using schwartzian transform.
> >   http://en.wikipedia.org/wiki/Schwartzian_transform
> 
> 
> Yeah, the idea is good, this can also make it more perlish. ;)
> 
> But...
> 
> 
> > -print sort bysize @stack;
> > +# Use Schwartzian transform to sort by last field (size)
> > +print map { $_->[0] }
> > +      sort { $b->[1] <=> $a->[1] }
> > +      map { [$_, /:\t*(\d+)$/] } @stack;
> 
> This regex here is not strictly the same as before.
> 
> Can we just keep the original regex? If not, what's wrong?

The original one had extra cruft:
  1. The expression is anchored on right, so leading .* is meaningless
  2. Putting tab directly makes it invisible when reading source (use \t)
  3. Want to match on number, not just anything (that is why the \d)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/