Date: Mon, 22 Feb 2010 21:08:27 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Valerie Aurora <vaurora@redhat.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>, linux-kernel@vger.kernel.org,
       linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] VFS: Simplify truncate logic in do_filp_open()
Message-ID: <20100222210827.GF30031@ZenIV.linux.org.uk>
References: <20100222203551.GE972@shell>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100222203551.GE972@shell>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 908
Lines: 18

On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote:
> The fact that may_open() could truncate a file gave me a lot of
> heartburn when working on union mounts, so I was thrilled to see that
> truncate handling has been moved out of may_open() in Al's for-next
> tree.  However, it seems to me that the surrounding elaborate
> mnt_want_write() dance is no longer needed?  If so, this also
> simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by
> mnt_drop_write()" patch.
> 
> Against Al's for-next branch.  Lightly tested, please review.

Val, anything around do_filp_open() should be on top of #untested.  The
whole area gets rewritten there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/