Date: Tue, 23 Feb 2010 12:58:46 +0100
From: Andrea Righi <arighi@develer.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: David Rientjes <rientjes@google.com>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       Suleiman Souhlal <suleiman@google.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memcg: dirty pages accounting and limiting
 infrastructure
Message-ID: <20100223115846.GI1882@linux>
References: <1266765525-30890-1-git-send-email-arighi@develer.com>
 <1266765525-30890-2-git-send-email-arighi@develer.com>
 <alpine.DEB.2.00.1002211321010.22858@chino.kir.corp.google.com>
 <20100221221700.GA5233@linux>
 <20100222180732.GC3096@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100222180732.GC3096@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 36

On Mon, Feb 22, 2010 at 01:07:32PM -0500, Vivek Goyal wrote:
> > > > +unsigned long mem_cgroup_dirty_bytes(void)
> > > > +{
> > > > +	struct mem_cgroup *memcg;
> > > > +	unsigned long dirty_bytes;
> > > > +
> > > > +	if (mem_cgroup_disabled())
> > > > +		return vm_dirty_bytes;
> > > > +
> > > > +	rcu_read_lock();
> > > > +	memcg = mem_cgroup_from_task(current);
> > > > +	if (memcg == NULL)
> > > > +		dirty_bytes = vm_dirty_bytes;
> > > > +	else
> > > > +		dirty_bytes = get_dirty_bytes(memcg);
> > > > +	rcu_read_unlock();
> > > 
> > > The rcu_read_lock() isn't protecting anything here.
> > 
> > Right!
> 
> Are we not protecting "memcg" pointer using rcu here?

Vivek, you are right:

 mem_cgroup_from_task() -> task_subsys_state() -> rcu_dereference()

So, this *must* be RCU protected.

Thanks!
-Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/