From: Thomas Renninger <trenn@suse.de>
Organization: SUSE Products GmbH
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec
Date: Tue, 23 Feb 2010 13:01:11 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.32.1-0.0.14.f17927a-desktop; KDE/4.3.1; x86_64; ; )
Cc: Kerstin Jonsson <kerstin.jonsson@ericsson.com>, jbohac@novell.com,
       "Yinghai Lu" <yinghai@kernel.org>, akpm@linux-foundation.org,
       mingo@elte.hu
References: <1266925885-17616-1-git-send-email-trenn@suse.de>
In-Reply-To: <1266925885-17616-1-git-send-email-trenn@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Message-Id: <201002231301.11372.trenn@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 590
Lines: 16

On Tuesday 23 February 2010 12:51:25 Thomas Renninger wrote:
> From: Kerstin Jonsson <kerstin.jonsson@ericsson.com>
...
> +	int i, j, acked = 0, max_loops = cpu_khz * 1000;
Grmpfl, an unsigned long for max_loops, probably is a better idea...
What do you think, could this one get picked up then, anything else
to improve?

Thanks,

      Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/