Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845Ab0BWPDc (ORCPT ); Tue, 23 Feb 2010 10:03:32 -0500 Received: from mailgw10.se.ericsson.net ([193.180.251.61]:50816 "EHLO mailgw10.se.ericsson.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480Ab0BWPD3 convert rfc822-to-8bit (ORCPT ); Tue, 23 Feb 2010 10:03:29 -0500 X-AuditID: c1b4fb3d-b7c72ae00000040e-01-4b83ee3fc938 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH] ARM: misplaced parentheses? Date: Tue, 23 Feb 2010 16:03:27 +0100 Message-ID: In-Reply-To: <4B7F2AA8.3010302@gmail.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] ARM: misplaced parentheses? Thread-Index: AcqxwVZh9a+r/qJVTzKWlbBkzaNfIwC18i2A References: <4B7F2AA8.3010302@gmail.com> From: "Linus Walleij" To: "Roel Kluin" , "Andrew Morton" , "LKML" Cc: "Russell King - ARM Linux" X-OriginalArrivalTime: 23 Feb 2010 15:03:26.0750 (UTC) FILETIME=[5A1063E0:01CAB499] X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 37 [Roel] > The parentheses appear misplaced. > > Signed-off-by: Roel Kluin > --- > Correct? > > diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c > index 0b35826..5f61fd4 100644 > --- a/arch/arm/mach-u300/gpio.c > +++ b/arch/arm/mach-u300/gpio.c > @@ -546,7 +546,7 @@ static void gpio_set_initial_values(void) > for (i = 0; i < U300_GPIO_MAX; i++) { > val = 0; > for (j = 0; j < 8; j++) > - val |= > (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j; > + val |= > (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j); > local_irq_save(flags); > writel(val, virtbase + U300_GPIO_PXPER + i * > U300_GPIO_PORTX_SPACING); > local_irq_restore(flags); Acked-by: Linus Walleij BTW this should go in through Russells patch tracker, can you put it there? http://www.arm.linux.org.uk/developer/patches/ Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/