Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992Ab0BWSct (ORCPT ); Tue, 23 Feb 2010 13:32:49 -0500 Received: from mail-fx0-f219.google.com ([209.85.220.219]:35356 "EHLO mail-fx0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710Ab0BWScr (ORCPT ); Tue, 23 Feb 2010 13:32:47 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=vJTzpGkHrxrekdH8GR4G7twkAsdnKikpRNrA95+3F4SoB4TRt92XJyCMZ7GbfdiqiN V7uRaPHNeL3pbA/Qgm9z7kQoVvIYCrK6wcaTZyndbSYeTu3GugparJuT5imGP8d4AJPl HI4PLD1ru/KJSclpBHx56rMMpgNOU4FsRoipQ= Subject: Re: [PATCH 10/15] MTD: nand: make reads using MTD_OOB_RAW affect only ECC validation From: Maxim Levitsky To: Thomas Gleixner Cc: David Woodhouse , linux-mtd , linux-kernel , Alex Dubov , joern , stanley.miao@windriver.com, Vitaly Wool In-Reply-To: References: <1266863982-5258-1-git-send-email-maximlevitsky@gmail.com> <1266863982-5258-11-git-send-email-maximlevitsky@gmail.com> <1266874087.4971.4.camel@maxim-laptop> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Feb 2010 20:32:40 +0200 Message-ID: <1266949960.8145.1.camel@maxim-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1696 Lines: 48 On Mon, 2010-02-22 at 22:29 +0100, Thomas Gleixner wrote: > On Mon, 22 Feb 2010, Maxim Levitsky wrote: > > On Mon, 2010-02-22 at 22:20 +0100, Thomas Gleixner wrote: > > > On Mon, 22 Feb 2010, Maxim Levitsky wrote: > > > > > > > This changes the behavier of MTD_OOB_RAW. It used to read both OOB and data > > > > to the data buffer, however you would still need to specify the dummy oob buffer. > > > > > > > > This is only used in one place, but makes it hard to read data+oob without ECC > > > > test, thus I removed that behavier, and fixed the user. > > > > > > > > Now MTD_OOB_RAW behaves just like MTD_OOB_PLACE, but doesn't do ECC validation > > > > > > Is this tested against existing user space tools like nanddump ? Can I > > > still get the raw data from flash ? > > > > Thats the point. > > Userspace doesn't/can't use that mode. > > It is not exposed through mtdchar. > > Userspace reads the page, and then reads the oob. > > > > It does use MTD_OOB_RAW, but without data buffer, and this path I don't > > change. > > > > The only user of this, is the nand itself, when it reads bad block > > table. > > > > I confess that I didn't run test that I ported this code correctly. > > But I did logically verified many times that the new code works just > > like old one. > > Well, then it's about time to run the tests :) > > Thanks, Just to be sure, I tested jffs2 and nanddump. Works just fine. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/