Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753934Ab0BWTbY (ORCPT ); Tue, 23 Feb 2010 14:31:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51065 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753706Ab0BWTbW (ORCPT ); Tue, 23 Feb 2010 14:31:22 -0500 From: Juan Quintela To: "Michael S. Tsirkin" Cc: Rusty Russell , kvm@vger.kernel.org, virtualization@lists.osdl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , markmc@redhat.com, gleb@redhat.com, herbert.xu@redhat.com, dlaor@redhat.com, avi@redhat.com Subject: Re: [PATCH 2/3] vhost: initialize log eventfd context pointer In-Reply-To: (Michael S. Tsirkin's message of "Tue, 23 Feb 2010 18:57:51 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Date: Tue, 23 Feb 2010 20:31:11 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 33 "Michael S. Tsirkin" wrote: > vq log eventfd context pointer needs to be initialized, otherwise > operation may fail or oops if log is enabled but log eventfd not set by > userspace. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Juan Quintela When log_ctx for device is created, it is copied to the vq. This reset was missing. > --- > drivers/vhost/vhost.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index c767279..d4f8fdf 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -121,6 +121,7 @@ static void vhost_vq_reset(struct vhost_dev *dev, > vq->kick = NULL; > vq->call_ctx = NULL; > vq->call = NULL; > + vq->log_ctx = NULL; > } > > long vhost_dev_init(struct vhost_dev *dev, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/