Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991Ab0BXJQ1 (ORCPT ); Wed, 24 Feb 2010 04:16:27 -0500 Received: from ernst.netinsight.se ([194.16.221.21]:54096 "HELO ernst.netinsight.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755316Ab0BXJQ0 convert rfc822-to-8bit (ORCPT ); Wed, 24 Feb 2010 04:16:26 -0500 Date: Wed, 24 Feb 2010 10:16:18 +0100 From: Simon Kagstrom To: =?ISO-8859-1?Q?P=E1draig?= Brady Cc: linux-kernel@vger.kernel.org, wim@iguana.be, seth.heasley@intel.com Subject: Re: [PATCH] iTCO_wdt: Don't double the requested timeout Message-ID: <20100224101618.39c3468b@marrow.netinsight.se> In-Reply-To: <4B840BC6.9090809@draigBrady.com> References: <20100223164019.60a6de1a@marrow.netinsight.se> <4B840154.1010501@draigBrady.com> <4B840BC6.9090809@draigBrady.com> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.16.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 18 On Tue, 23 Feb 2010 17:09:26 +0000 P?draig Brady wrote: > Actually looking at that code I noticed that it wasn't > accounting for the timer counting down twice before reboot, > which I thought was the case for ICH4 at least. > The following is not even compiled, nor am I sure it > applies to TCO v2. Testing/info appreciated. I tested your change on our TCO v1-based board, and it doubles the time until the watchdog triggers. So: Tested-by: Simon Kagstrom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/