Date: Wed, 24 Feb 2010 10:03:15 +0000
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/14] Assorted small patches for regulators
Message-ID: <20100224100314.GA18896@rakim.wolfsonmicro.main>
References: <20100224073342.15964.8863.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100224073342.15964.8863.stgit@localhost.localdomain>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1278
Lines: 24

On Tue, Feb 23, 2010 at 11:37:39PM -0800, Dmitry Torokhov wrote:

> I happend to peek into drivers/regulator and saw a bunch of small issues, so
> here goes. The patches are against linux-next, compile-tested only since I
> don't have the hardware,

I'm working through these now, but a few general issues:

 - It'd be very much easier to review patches that do one thing at once,
   especially when the patches do things more invasive than just adding
   annotations or changing types.  The random cleanup stuff makes the
   invasive changes much harder to see and review.
 - Frequently your patches include additional changes above those that
   you list in the changelog which again increases the effort require to
   reviwe - things like random whitespace changes and the addition of
   module annotations seem particularly prone to this.
 - Please always use a subject line for your patches which fits the
   style of the subsystem.  You're using "Regulators:" as a prefix when
   pretty much everything else uses "regulator:".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/