Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 21 Apr 2002 06:20:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 21 Apr 2002 06:20:31 -0400 Received: from fungus.teststation.com ([212.32.186.211]:38925 "EHLO fungus.teststation.com") by vger.kernel.org with ESMTP id ; Sun, 21 Apr 2002 06:20:30 -0400 Date: Sun, 21 Apr 2002 12:19:40 +0200 (CEST) From: Urban Widmark X-X-Sender: To: "Ivan G." cc: Shing Chuang , LKML , Jeff Garzik Subject: Re: [PATCH] Via-rhine minor issues In-Reply-To: <02042101022001.00833@cobra.linux> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Apr 2002, Ivan G. wrote: > DIFF-ED AGAINST: > 2.4.19-pre3 ( I don't think there were changes to via-rhine > b-ween pre3 and pre7) You should probably send this to Jeff Garzik instead of Marcelo. Jeff collects net driver patches. If you don't, Shing Chuang's changes are in -pre7-ac2, so a re-diff vs that and seding it to Alan Cox may cause less merge work. > - changed chip_id in wait_for_reset as parameter since np is not initialized > the first time this function is called (should this be fixed differently?) I think that is an ok change. np could be initialised sooner instead but I don't know why that would be better. > - change "Something Wicked" message to "PCI Error" (I still don't see the > purpose of the trap) To trap things ... :) Maybe there should be a trap for all the unhandled interrupt status error events. via_rhine_interrupt could list more Intr flags as reasons to call via_rhine_error, if you know which ones are errors. /Urban - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/