DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=RrOqqagi4WCF5mxB3Ws7mIvJch2FsQ49x4OeFuMlaqBdz/HNVCraTDtiTbLSJUpK+Q
         Yugx+ovOOjvbqQradpMHPpL10f2ahyP+UzDI2xHA1uPgpNlGkd5V8xspEuPyoH1xCDoI
         taViGoT/L7SCtTwy0E3HTQrE469DsrevVYYks=
MIME-Version: 1.0
In-Reply-To: <20100224200559.fa911282.akpm@linux-foundation.org>
References: <808c8e9d1002231455q379b26acq4b4a50188c5d73be@mail.gmail.com>
	 <20100224145822.803e86ed.akpm@linux-foundation.org>
	 <808c8e9d1002241952s63633da3m471b6fb170558789@mail.gmail.com>
	 <20100224200559.fa911282.akpm@linux-foundation.org>
Date: Wed, 24 Feb 2010 22:16:43 -0600
Message-ID: <808c8e9d1002242016j52d763e3wb0b00c73a014e6e5@mail.gmail.com>
Subject: Re: [PATCH] cs5535_gpio: gpio_chip.get should return the input value
From: Ben Gardner <gardner.ben@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andres Salomon <dilinger@collabora.co.uk>, linux-kernel@vger.kernel.org,
       stable@kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1266
Lines: 33

>> > What were the user-visible effects of this bug?
>>
>> The user-visible effects were that the input didn't work.
>> I use the CS5535 chip in a custom board that uses GPIO 25 and 26 as
>> voltage monitoring inputs (external voltage comparators).
>> Since the char-based cs5535-gpio is now deprecated, I'm trying out the
>> gpio driver.
>> I export the GPIO pins via sysfs to access them from user-space.
>> Reading the 'value' member didn't reflect the input.
>
> OK, then in that case we'd want to backport this into 2.6.33.x and
> perhaps earlier?

It looks like the driver was added 15 Dec 2009, so it doesn't look
like it existed in an earlier kernel.

>> Personally, I would prefer a separate sysfs entry for the output and
>> the input, since the GPIO pins can be both outputs and inputs, but
>> that would require a gpiolib change.
>> Since there doesn't appear to be a gpio maintainer, any change to that
>> might be tricky.
>
> Eh, we can cope. ?Propose a patch and cc lots of people..

Will do.

Thanks,
Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/