Date: Thu, 25 Feb 2010 00:04:02 -0500
From: Andres Salomon <dilinger@collabora.co.uk>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       stable@kernel.org
Subject: Re: [PATCH] cs5535_gpio: gpio_chip.get should return the input
 value
Message-ID: <20100225000402.0951a473@droptest.queued.net>
In-Reply-To: <808c8e9d1002242016j52d763e3wb0b00c73a014e6e5@mail.gmail.com>
References: <808c8e9d1002231455q379b26acq4b4a50188c5d73be@mail.gmail.com>
	<20100224145822.803e86ed.akpm@linux-foundation.org>
	<808c8e9d1002241952s63633da3m471b6fb170558789@mail.gmail.com>
	<20100224200559.fa911282.akpm@linux-foundation.org>
	<808c8e9d1002242016j52d763e3wb0b00c73a014e6e5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 26

On Wed, 24 Feb 2010 22:16:43 -0600
Ben Gardner <gardner.ben@gmail.com> wrote:

> >> > What were the user-visible effects of this bug?
> >>
> >> The user-visible effects were that the input didn't work.
> >> I use the CS5535 chip in a custom board that uses GPIO 25 and 26 as
> >> voltage monitoring inputs (external voltage comparators).
> >> Since the char-based cs5535-gpio is now deprecated, I'm trying out
> >> the gpio driver.
> >> I export the GPIO pins via sysfs to access them from user-space.
> >> Reading the 'value' member didn't reflect the input.
> >
> > OK, then in that case we'd want to backport this into 2.6.33.x and
> > perhaps earlier?
> 
> It looks like the driver was added 15 Dec 2009, so it doesn't look
> like it existed in an earlier kernel.

But it should definitely be added to 2.6.33.y.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/