Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759232Ab0BYKhe (ORCPT ); Thu, 25 Feb 2010 05:37:34 -0500 Received: from mail-fx0-f219.google.com ([209.85.220.219]:56994 "EHLO mail-fx0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759199Ab0BYKh3 (ORCPT ); Thu, 25 Feb 2010 05:37:29 -0500 Subject: Re: [PATCH 07/14] Regulators: lp3971 - fail if platform data was not supplied From: Liam Girdwood To: Dmitry Torokhov Cc: Mark Brown , linux-kernel@vger.kernel.org In-Reply-To: <20100224073817.15964.82625.stgit@localhost.localdomain> References: <20100224073342.15964.8863.stgit@localhost.localdomain> <20100224073817.15964.82625.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Thu, 25 Feb 2010 10:37:25 +0000 Message-ID: <1267094245.4037.127.camel@odin> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 26 On Tue, 2010-02-23 at 23:38 -0800, Dmitry Torokhov wrote: > There is no point in completing probe if platform data is missing so > let's abort loading early. > > Also, use kcalloc when allocating several instances of the same data > structure and mark setup_regulators() as __devinit since it is only > called from lp3971_i2c_probe() which is __devinit. > > Signed-off-by: Dmitry Torokhov Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/