Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759270Ab0BYLOa (ORCPT ); Thu, 25 Feb 2010 06:14:30 -0500 Received: from mail-iw0-f202.google.com ([209.85.223.202]:55570 "EHLO mail-iw0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165Ab0BYLO2 (ORCPT ); Thu, 25 Feb 2010 06:14:28 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=DyLxjmSf2JYYTl99v/UA+pS+KWIpL3sxj/bemVABEC86Il/S36udSYoazVqnt8QoCi pK92FkxCdV50rVkanxpta3toTXCL+tgpvaWK8dKa/Rorg69agDQ5mFYMe4VZ4oviAEm5 0UWNboEUaJQLg4HhNyIsbI1k7k/hEbr0PCnik= MIME-Version: 1.0 In-Reply-To: <1266953763.32702.49.camel@quad> References: <1266953763.32702.49.camel@quad> Date: Thu, 25 Feb 2010 13:14:27 +0200 Message-ID: <94a0d4531002250314o4a1d08cclceb20e991c51d829@mail.gmail.com> Subject: Re: [PATCH] omap2_mcspi.c: NULL pointer dereference From: Felipe Contreras To: Scott Ellis Cc: linux-kernel@vger.kernel.org, David Brownell , Andrew Morton , Tony Lindgren , Kevin Hilman , Aaro Koskinen , spi-devel-general@lists.sourceforge.net, gumstix-users@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 16 On Tue, Feb 23, 2010 at 9:36 PM, Scott Ellis wrote: > Check spi->controller_state before dereferencing. > > Shows up NULL here when using spi_alloc_device()/spi_add_device() > and spi_add_device() fails before spi_setup(). Calling spi_dev_put() > on the leftover spi_device results in the error. This should go to the linux-omap mailing list. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/