Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242Ab0BYLcw (ORCPT ); Thu, 25 Feb 2010 06:32:52 -0500 Received: from legolas.restena.lu ([158.64.1.34]:40775 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932149Ab0BYLcu convert rfc822-to-8bit (ORCPT ); Thu, 25 Feb 2010 06:32:50 -0500 Date: Thu, 25 Feb 2010 12:32:14 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel Subject: Re: [PATCH 1/3] picolcd: driver for PicoLCD HID device Message-ID: <20100225123214.0523a310@neptune.home> In-Reply-To: References: <20100221002001.0a7e05a7@neptune.home> <20100224170049.0d04af3c@neptune.home> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.16.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3083 Lines: 80 On Thu, 25 February 2010 Jiri Kosina wrote: > On Wed, 24 Feb 2010, Bruno Prémont wrote: > > > +config HID_PICOLCD > > + tristate "Minibox PicoLCD (graphic version)" > > + depends on FB > > + select FB_DEFERRED_IO > > + select FB_SYS_FILLRECT > > + select FB_SYS_COPYAREA > > + select FB_SYS_IMAGEBLIT > > + select FB_SYS_FOPS > > + select BACKLIGHT_LCD_SUPPORT > > + select BACKLIGHT_CLASS_DEVICE > > + select LCD_CLASS_DEVICE > > I guess you need dependency on USB_HID as well, right? Yep, will add > > --- a/drivers/hid/hid-picolcd.c > > +++ b/drivers/hid/hid-picolcd.c > > @@ -0,0 +1,1075 @@ > > +/*************************************************************************** > > + * Copyright (C) 2010 by Bruno Prémont * > > + * * > > + * Based on Logitech G13 driver (v0.4) * > > + * Copyright (C) 2009 by Rick L. Vinyard, Jr. * > > + * * > > + * This program is free software: you can redistribute it and/or modify * > > + * it under the terms of the GNU General Public License as published by * > > + * the Free Software Foundation, either version 2 of the License. * > > I support removing the 'or any later' clause, but I think your > version has the grammar wrong :) Oops, will fix > > +/* Update fb_vbitmap from the screen_base and send changed tiles to device */ > > +static void picolcd_fb_update(struct picolcd_data *data) > > +{ > > + int chip, tile; > > + > > + spin_lock(&data->lock); > > + if (!(data->status & PICOLCD_READY_FB)) { > > + spin_unlock(&data->lock); > > + picolcd_fb_reset(data->hdev, 0); > > + } else > > + spin_unlock(&data->lock); > > Please put the brackets to the else branch as well. Ok, will add the brackets while switching from spin_(un)lock to spin_(un)lock_irq{save|restore}. > Also, it'd be great if the framebuffer part would get Ack from > someone more familiar with framebuffer code than me. I would appreciate such one as well, especially regarding the deferredio part and the more advanced fb use. For now I only tested read/write from /dev/fbx. For the two sysfs attributes I currently use, the 'reset' one shall probably be moved to debugfs (I would like to place it under /sys/kernel/debug/hid/$device/ next to rdesc and event). By the way, I'm wondering why event does not list any of the reports coming from my device though as I understand the code it should be doing that before my raw_event function gets called... The one for deferredio refresh rate should ideally go below fb device (and I guess that might also be of use for other users of deferredio) Thanks for the review, Bruno -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/