Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932993Ab0BYTZm (ORCPT ); Thu, 25 Feb 2010 14:25:42 -0500 Received: from ovro.ovro.caltech.edu ([192.100.16.2]:45929 "EHLO ovro.ovro.caltech.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932633Ab0BYTZl (ORCPT ); Thu, 25 Feb 2010 14:25:41 -0500 Date: Thu, 25 Feb 2010 11:25:39 -0800 From: "Ira W. Snyder" To: Guennadi Liakhovetski Cc: "Steven J. Magnani" , Zhang Wei , Dan Williams , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [async_tx-next PATCH 2/2] fsldma: Fix cookie issues Message-ID: <20100225192539.GB32092@ovro.caltech.edu> References: <1266860439-17352-1-git-send-email-steve@digidescorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (ovro.ovro.caltech.edu); Thu, 25 Feb 2010 11:25:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 29 On Mon, Feb 22, 2010 at 09:26:13PM +0100, Guennadi Liakhovetski wrote: > On Mon, 22 Feb 2010, Steven J. Magnani wrote: > > > diff -uprN a/include/linux/dmaengine.h b/include/linux/dmaengine.h > > --- a/include/linux/dmaengine.h 2010-02-22 11:18:11.000000000 -0600 > > +++ b/include/linux/dmaengine.h 2010-02-22 11:18:30.000000000 -0600 > > @@ -31,6 +31,8 @@ > > * if dma_cookie_t is >0 it's a DMA request cookie, <0 it's an error code > > */ > > typedef s32 dma_cookie_t; > > +#define DMA_MIN_COOKIE 1 > > +#define DMA_MAX_COOKIE 2147483647 > > Taking into account, that dma_cookie_t is 32 bits: > > +#define DMA_MAX_COOKIE ((1 << 31) - 1) > Steven, After you take Guennadi's comment into acount, the rest of the patch looks good. I'm sure I've never rolled the cookie around during testing. Ira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/