Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933917Ab0BYVXK (ORCPT ); Thu, 25 Feb 2010 16:23:10 -0500 Received: from mail.windriver.com ([147.11.1.11]:63592 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933841Ab0BYVWf (ORCPT ); Thu, 25 Feb 2010 16:22:35 -0500 From: Jason Wessel To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Jason Wessel , Steven Rostedt Subject: [PATCH 28/28] debug_core: Turn off tracing while in the debugger Date: Thu, 25 Feb 2010 15:21:33 -0600 Message-Id: <1267132893-23624-29-git-send-email-jason.wessel@windriver.com> X-Mailer: git-send-email 1.6.4.rc1 In-Reply-To: <1267132893-23624-1-git-send-email-jason.wessel@windriver.com> References: <1267132893-23624-1-git-send-email-jason.wessel@windriver.com> X-OriginalArrivalTime: 25 Feb 2010 21:22:05.0133 (UTC) FILETIME=[941A07D0:01CAB660] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 57 The kernel debugger should turn off kernel tracing any time the debugger is active and restore it on resume. CC: Steven Rostedt Signed-off-by: Jason Wessel --- kernel/debug/debug_core.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index ed42d9e..3d36d9e 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -474,6 +474,7 @@ static int kgdb_cpu_enter(struct kgdb_state *ks, struct pt_regs *regs) int sstep_tries = 100; int error; int i, cpu; + int trace_on = 0; acquirelock: /* * Interrupts will be restored by the 'trap return' code, except when @@ -518,6 +519,8 @@ return_normal: */ if (arch_kgdb_ops.correct_hw_break) arch_kgdb_ops.correct_hw_break(); + if (trace_on) + tracing_on(); atomic_set(&cpu_in_kgdb[cpu], 0); touch_softlockup_watchdog_sync(); clocksource_touch_watchdog(); @@ -592,6 +595,9 @@ return_normal: kgdb_single_step = 0; kgdb_contthread = current; exception_level = 0; + trace_on = tracing_is_on(); + if (trace_on) + tracing_off(); while (1) { cpu_master_loop: @@ -645,6 +651,8 @@ kgdb_restore: else kgdb_sstep_pid = 0; } + if (trace_on) + tracing_on(); /* Free kgdb_active */ atomic_set(&kgdb_active, -1); touch_softlockup_watchdog_sync(); -- 1.6.4.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/