Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934259Ab0BYWXA (ORCPT ); Thu, 25 Feb 2010 17:23:00 -0500 Received: from tundra.namei.org ([65.99.196.166]:47937 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934190Ab0BYWW6 (ORCPT ); Thu, 25 Feb 2010 17:22:58 -0500 Date: Fri, 26 Feb 2010 09:22:18 +1100 (EST) From: James Morris To: Tetsuo Handa cc: linux-security-module@vger.kernel.org, Al Viro , linux-kernel@vger.kernel.org, oleg@redhat.com, tglx@linutronix.de, Andrew Morton , Eric Paris Subject: Re: [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU. In-Reply-To: <201002250819.o1P8JPwQ063834@www262.sakura.ne.jp> Message-ID: References: <201002240034.o1O0YoMd068517@www262.sakura.ne.jp> <201002250013.o1P0DHml057484@www262.sakura.ne.jp> <201002250819.o1P8JPwQ063834@www262.sakura.ne.jp> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 24 On Thu, 25 Feb 2010, Tetsuo Handa wrote: > I see. Explanation is in commit d4581a239a40319205762b76c01eb6363f277efa > "sys: Fix missing rcu protection for __task_cred() access". > Thus, I think below comment should be sufficient. > -------------------- > [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU. > > Holding tasklist_lock is no longer sufficient for find_task_by_vpid(). > Explicit rcu_read_lock() is required. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next The audit code still looks like it needs to be updated. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/