Date: Thu, 25 Feb 2010 15:50:54 -0800
From: Greg KH <greg@kroah.com>
To: Graham M Howe <gman.1352@googlemail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in
 ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and
 kfree issue found by checkpatch.pl tool Signed-off-by: Graham M
 Howe<gman.1352@googlemail.com>
Message-ID: <20100225235054.GE24155@kroah.com>
References: <1266666781-2178-1-git-send-email-gman.1352@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1266666781-2178-1-git-send-email-gman.1352@googlemail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 982
Lines: 26

The subject doesn't match what the patch did :(

On Sat, Feb 20, 2010 at 11:53:01AM +0000, Graham M Howe wrote:
> ---
>  drivers/staging/comedi/drivers/ni_670x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
> index fc5f90f..352b917 100644
> --- a/drivers/staging/comedi/drivers/ni_670x.c
> +++ b/drivers/staging/comedi/drivers/ni_670x.c
> @@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
>  {
>  	printk("comedi%d: ni_670x: remove\n", dev->minor);
> 
> -	if (dev->subdevices[0].range_table_list)
> -		kfree(dev->subdevices[0].range_table_list);

You can't just not free the memory :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/