Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935208Ab0BZLln (ORCPT ); Fri, 26 Feb 2010 06:41:43 -0500 Received: from one.firstfloor.org ([213.235.205.2]:34016 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934718Ab0BZLlm (ORCPT ); Fri, 26 Feb 2010 06:41:42 -0500 Date: Fri, 26 Feb 2010 12:41:36 +0100 From: Andi Kleen To: Christoph Lameter Cc: David Rientjes , Pekka Enberg , Andi Kleen , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com, KAMEZAWA Hiroyuki Subject: Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Message-ID: <20100226114136.GA16335@basil.fritz.box> References: <20100215103250.GD21783@one.firstfloor.org> <20100215104135.GM5723@laptop> <20100215105253.GE21783@one.firstfloor.org> <20100215110135.GN5723@laptop> <20100220090154.GB11287@basil.fritz.box> <4B862623.5090608@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 28 On Thu, Feb 25, 2010 at 12:30:26PM -0600, Christoph Lameter wrote: > On Thu, 25 Feb 2010, David Rientjes wrote: > > > I don't see how memory hotadd with a new node being onlined could have > > worked fine before since slab lacked any memory hotplug notifier until > > Andi just added it. > > AFAICR The cpu notifier took on that role in the past. The problem is that slab already allocates inside the notifier and then some state wasn't set up. > If what you say is true then memory hotplug has never worked before. > Kamesan? Memory hotplug with node add never quite worked on x86 before, for various reasons not related to slab. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/