Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935813Ab0BZMDQ (ORCPT ); Fri, 26 Feb 2010 07:03:16 -0500 Received: from exprod5og108.obsmtp.com ([64.18.0.186]:60673 "EHLO exprod5og108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935641Ab0BZMDO (ORCPT ); Fri, 26 Feb 2010 07:03:14 -0500 Message-ID: <4B87B937.6010204@ge.com> Date: Fri, 26 Feb 2010 12:06:15 +0000 From: Martyn Welch User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: avorontsov@ru.mvista.com CC: Paul Gortmaker , linuxppc-dev list , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sandeep Gopalpet , davem@davemloft.net, Kumar Gala Subject: Re: Gianfar driver failing on MPC8641D based board References: <4B6C2488.3060403@ge.com> <4B865176.7080806@ge.com> <4B86A97E.6050509@ge.com> <20100225165141.GA9686@oksana.dev.rtsoft.ru> <20100225174935.GA32370@oksana.dev.rtsoft.ru> <7d1d9c251002251653n6473f01ex2d43933ec6aa010b@mail.gmail.com> <20100226031452.GA11319@oksana.dev.rtsoft.ru> In-Reply-To: <20100226031452.GA11319@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1936 Lines: 57 Anton Vorontsov wrote: > On Thu, Feb 25, 2010 at 07:53:30PM -0500, Paul Gortmaker wrote: > [...] > >> I was able to reproduce it on an 8641D and bisected it down to this: >> >> ----------- >> commit a3bc1f11e9b867a4f49505ecac486a33af248b2e >> Author: Anton Vorontsov >> Date: Tue Nov 10 14:11:10 2009 +0000 >> >> gianfar: Revive SKB recycling >> > > Thanks for the bisect. I have a guess why tx hangs in > SMP case. Could anyone try the patch down below? > Yup, no problem. I'm afraid it doesn't resolve the problem for me. > [...] > >> ...which probably explains why you weren't seeing it on non-SMP. >> I'd imagine it would show up on any of the e500mc boards too. >> > > Yeah.. Pity, I don't have SMP boards anymore. I'll try > to get one though. > > > diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c > index 8bd3c9f..3ff3bd0 100644 > --- a/drivers/net/gianfar.c > +++ b/drivers/net/gianfar.c > @@ -2614,6 +2614,8 @@ static int gfar_poll(struct napi_struct *napi, int budget) > tx_queue = priv->tx_queue[rx_queue->qindex]; > > tx_cleaned += gfar_clean_tx_ring(tx_queue); > + if (!tx_cleaned && !tx_queue->num_txbdfree) > + tx_cleaned += 1; /* don't complete napi */ > rx_cleaned_per_queue = gfar_clean_rx_ring(rx_queue, > budget_per_queue); > rx_cleaned += rx_cleaned_per_queue; > -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@ge.com | M2 3AB VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/