Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964890Ab0BZOfg (ORCPT ); Fri, 26 Feb 2010 09:35:36 -0500 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:60017 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S964865Ab0BZOfe (ORCPT ); Fri, 26 Feb 2010 09:35:34 -0500 Date: Fri, 26 Feb 2010 17:35:32 +0300 From: Anton Vorontsov To: Martyn Welch Cc: linuxppc-dev list , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Sandeep Gopalpet , davem@davemloft.net Subject: Re: Gianfar driver failing on MPC8641D based board Message-ID: <20100226143532.GA31622@oksana.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <4B6C2488.3060403@ge.com> <4B865176.7080806@ge.com> <4B86A97E.6050509@ge.com> <20100225165141.GA9686@oksana.dev.rtsoft.ru> <20100225174935.GA32370@oksana.dev.rtsoft.ru> <7d1d9c251002251653n6473f01ex2d43933ec6aa010b@mail.gmail.com> <20100226031452.GA11319@oksana.dev.rtsoft.ru> <4B87B937.6010204@ge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4B87B937.6010204@ge.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2004 Lines: 60 On Fri, Feb 26, 2010 at 12:06:15PM +0000, Martyn Welch wrote: > Anton Vorontsov wrote: > > On Thu, Feb 25, 2010 at 07:53:30PM -0500, Paul Gortmaker wrote: > > [...] > > > >> I was able to reproduce it on an 8641D and bisected it down to this: > >> > >> ----------- > >> commit a3bc1f11e9b867a4f49505ecac486a33af248b2e > >> Author: Anton Vorontsov > >> Date: Tue Nov 10 14:11:10 2009 +0000 > >> > >> gianfar: Revive SKB recycling > >> > > > > Thanks for the bisect. I have a guess why tx hangs in > > SMP case. Could anyone try the patch down below? > > > > Yup, no problem. I'm afraid it doesn't resolve the problem for me. Hm.. I found a p2020 board and I was able to reproduce the issue. The patch down below fixed it completely for me... hm. I'll look further, thanks! > > [...] > > > >> ...which probably explains why you weren't seeing it on non-SMP. > >> I'd imagine it would show up on any of the e500mc boards too. > >> > > > > Yeah.. Pity, I don't have SMP boards anymore. I'll try > > to get one though. > > > > > > diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c > > index 8bd3c9f..3ff3bd0 100644 > > --- a/drivers/net/gianfar.c > > +++ b/drivers/net/gianfar.c > > @@ -2614,6 +2614,8 @@ static int gfar_poll(struct napi_struct *napi, int budget) > > tx_queue = priv->tx_queue[rx_queue->qindex]; > > > > tx_cleaned += gfar_clean_tx_ring(tx_queue); > > + if (!tx_cleaned && !tx_queue->num_txbdfree) > > + tx_cleaned += 1; /* don't complete napi */ > > rx_cleaned_per_queue = gfar_clean_rx_ring(rx_queue, > > budget_per_queue); > > rx_cleaned += rx_cleaned_per_queue; > > -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/