Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966778Ab0B0BFG (ORCPT ); Fri, 26 Feb 2010 20:05:06 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33662 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966750Ab0B0BFD (ORCPT ); Fri, 26 Feb 2010 20:05:03 -0500 Date: Fri, 26 Feb 2010 17:04:19 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List , DRI Subject: Re: [PATCH][RFC] time: add wait_interruptible_timeout macro to sleep (w. timeout) until wake_up In-Reply-To: Message-ID: References: <1266761422-2921-1-git-send-email-zajec5@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 21 On Fri, 26 Feb 2010, Rafał Miłecki wrote: > > Following macro is soemthing that seems to work fine for us, but instead > introducing this to radeon KMS only, I'd like to propose adding this to whole > wait.h. Do you this it's something we should place there? Can someone take this > patch for me? Or maybe you find this rather useless and we should keep this > marco locally? This does not smell generic to me. In fact, it makes me personally think you're doing something wrong in the first place, but maybe it's ok. But in case it really is ok, I'd still not put it in a generic header file unless you can point to other cases where it really makes sense to do this. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/