Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967770Ab0B0D50 (ORCPT ); Fri, 26 Feb 2010 22:57:26 -0500 Received: from kroah.org ([198.145.64.141]:34748 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585Ab0B0D5O (ORCPT ); Fri, 26 Feb 2010 22:57:14 -0500 Date: Fri, 26 Feb 2010 19:56:39 -0800 From: Greg KH To: Markus Rechberger Cc: werner@guyane.dyn-o-saur.com, Linus Torvalds , Marcus Meissner , linux-kernel@vger.kernel.org Subject: Re: 2.6.33 bugs (USBFS, Intel graphic) Message-ID: <20100227035639.GA11680@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 42 On Sat, Feb 27, 2010 at 04:42:53AM +0100, Markus Rechberger wrote: > * http://lkml.org/lkml/2010/2/19/192 > .6.32-stable review patch. If anyone has any objections, please let us know. > > ------------------ > From: Greg KH > > commit d4a4683ca054ed9917dfc9e3ff0f7ecf74ad90d6 upstream. > > We need to only copy the data received by the device to userspace, not > the whole kernel buffer, which can contain "stale" data. > > Thanks to Marcus Meissner for pointing this out and testing the fix. > > Reported-by: Marcus Meissner > Tested-by: Marcus Meissner > Cc: Alan Stern > Cc: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman > > > this patch breaks isochronous USBFS support, please revert that patch! > > http://sundtek.de/images/tvtime-bildfehler.jpg > > with the patch reverted: > http://sundtek.de/images/tvtime-working.png > > * Intel graphic flickers now That is very strange. What userspace program is using usbfs for video feeds? And why would it be relying on the invalid data on the end of an urb? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/