Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967821Ab0B0E3i (ORCPT ); Fri, 26 Feb 2010 23:29:38 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54488 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967794Ab0B0E3h (ORCPT ); Fri, 26 Feb 2010 23:29:37 -0500 Date: Fri, 26 Feb 2010 20:29:28 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Greg KH cc: Markus Rechberger , linux-usb@vger.kernel.org, werner@guyane.dyn-o-saur.com, Marcus Meissner , linux-kernel@vger.kernel.org Subject: Re: 2.6.33 bugs (USBFS, Intel graphic) In-Reply-To: <20100227041815.GA12956@kroah.com> Message-ID: References: <20100227035639.GA11680@kroah.com> <20100227041815.GA12956@kroah.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 25 On Fri, 26 Feb 2010, Greg KH wrote: > > Yes, and that patch didn't touch the iso frames. That happens later on > in the functions that were modified. The patch should not have had any > affect on iso transfers. Unless I'm missing something? Hmm. What seems to happen is that for an isochronous transfer, the buffer is split for each microframe. No? So the total length may be in 'urb->actual_length', but the actual data in the buffer may not be contiguous, because it's created from multiple smaller frames, some of which might not be full length? I dunno. That would explain the problem - actual_length is correct, but the 'copy_to_user()' still doesn't copy all the data, because it's fragmented. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/