DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=IbmGo7rkQpm85ikxBgQmtFSojAXxq5wHVNR1VeADzwFUaCxvtDk6hqRKF0a64hKg63kTG7W/1lkbVA0q1g/Lahtfr2CRDsyM5rPW4meakwFiUSVuqAU3BfpLvNCcY3g4GkZJT9i5N1zfWX98QGsgCsIE+Cff0FSYqykBdpFwXSU=  ;
From: David Brownell <david-b@pacbell.net>
To: Ben Gardner <gardner.ben@gmail.com>
Subject: Re: [PATCH 2/3] cs5535-gpio: Use set_direction
Date: Fri, 26 Feb 2010 23:04:49 -0800
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org, Andres Salomon <dilinger@collabora.co.uk>,
       Andrew Morton <akpm@linux-foundation.org>,
       David Brownell <dbrownell@users.sourceforge.net>,
       Jani Nikula <ext-jani.1.nikula@nokia.com>
References: <cover.1267225701.git.gardner.ben@gmail.com> <6787cce8528c344c496724509762b2a11dea4bfb.1267225701.git.gardner.ben@gmail.com>
In-Reply-To: <6787cce8528c344c496724509762b2a11dea4bfb.1267225701.git.gardner.ben@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201002262304.49768.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 25

On Friday 26 February 2010, Ben Gardner wrote:
> The CS5535 GPIO has independant controls for input and output enable.

Unusual, but not causing any conceptual problem.


> Use the set_direction method instead of direction_input and direction_output
> to enable use of the bidirectional mode.

Any reason you aren't making the standard behavior be:

	input ... input enabled
	output ... both enabled

That would make this driver behave like most other GPIO hardware, which
would help you avoid subtle problems.

Would there be any technical downside to that approach?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/