Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030658Ab0B0S43 (ORCPT ); Sat, 27 Feb 2010 13:56:29 -0500 Received: from mail-iw0-f182.google.com ([209.85.223.182]:34730 "EHLO mail-iw0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030492Ab0B0S42 (ORCPT ); Sat, 27 Feb 2010 13:56:28 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=ehTBcqdxzs1kZfIhFrOTUXXGpgzwO/diSlgx7+5Gjzn7rapitpP2E0Fzm9+jNhV9m5 +P+/iSy/HTu7UoStcxmCiPksjjiBMZaxEx2a9pmJ7ugqFORs25ClJ7u0Es4OBQeqaxw9 Ujx7SaX73m5OPNJraq7d0OEOenkUgLXeTDZXY= From: Ben Gardner To: linux-kernel@vger.kernel.org, Andres Salomon , Mark Brown , David Brownell Cc: Ben Gardner , Andres Salomon , Andrew Morton , David Brownell , Jani Nikula Subject: [PATCH v2] cs5535-gpio: change input/output enable to match gpiolib expectations Date: Sat, 27 Feb 2010 12:56:17 -0600 Message-Id: <1267296977-22626-1-git-send-email-gardner.ben@gmail.com> X-Mailer: git-send-email 1.7.0 In-Reply-To: <14e456b7d269efd860bb36c312de2bc4ad504dca.1267225701.git.gardner.ben@gmail.com> References: <14e456b7d269efd860bb36c312de2bc4ad504dca.1267225701.git.gardner.ben@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 43 The intent of the gpiolib set_direction_xxx functions is as follows: output: enable both input and output input: disable output, enable input Change the cs5535 driver to do that. Signed-off-by: Ben Gardner CC: Andres Salomon CC: Andrew Morton CC: David Brownell CC: Jani Nikula --- drivers/gpio/cs5535-gpio.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/cs5535-gpio.c b/drivers/gpio/cs5535-gpio.c index 0fdbe94..de064c9 100644 --- a/drivers/gpio/cs5535-gpio.c +++ b/drivers/gpio/cs5535-gpio.c @@ -171,6 +171,7 @@ static int chip_direction_input(struct gpio_chip *c, unsigned offset) unsigned long flags; spin_lock_irqsave(&chip->lock, flags); + __cs5535_gpio_clear(chip, offset, GPIO_OUTPUT_ENABLE); __cs5535_gpio_set(chip, offset, GPIO_INPUT_ENABLE); spin_unlock_irqrestore(&chip->lock, flags); @@ -185,6 +186,7 @@ static int chip_direction_output(struct gpio_chip *c, unsigned offset, int val) spin_lock_irqsave(&chip->lock, flags); __cs5535_gpio_set(chip, offset, GPIO_OUTPUT_ENABLE); + __cs5535_gpio_set(chip, offset, GPIO_INPUT_ENABLE); if (val) __cs5535_gpio_set(chip, offset, GPIO_OUTPUT_VAL); else -- 1.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/