Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982Ab0DAHfo (ORCPT ); Thu, 1 Apr 2010 03:35:44 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:39688 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656Ab0DAHfi (ORCPT ); Thu, 1 Apr 2010 03:35:38 -0400 Date: Thu, 1 Apr 2010 18:35:30 +1100 From: Stephen Rothwell To: Jiri Kosina Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Subject: Re: linux-next: build failure after merge of the final tree (hid tree related) Message-Id: <20100401183530.516bbca6.sfr@canb.auug.org.au> In-Reply-To: References: <20100401170639.9f2fe605.sfr@canb.auug.org.au> X-Mailer: Sylpheed 3.0.1 (GTK+ 2.18.9; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Thu__1_Apr_2010_18_35_30_+1100_Juv1ed00kvd2lyd9" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2039 Lines: 63 --Signature=_Thu__1_Apr_2010_18_35_30_+1100_Juv1ed00kvd2lyd9 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jiri, On Thu, 1 Apr 2010 08:18:43 +0200 (CEST) Jiri Kosina wrot= e: > > On Thu, 1 Apr 2010, Stephen Rothwell wrote: >=20 > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > >=20 > > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write': > > drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function= 'copy_from_user' > > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read': > > drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function= 'copy_to_user' > >=20 > > Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add > > experimental access to PicoLCD device's EEPROM and FLASH"). Using copy_ > > {to,from}_user requires the include of linux/uaccess.h. > >=20 > > I have reverted that commit for today. >=20 > Hmm, on which arch did this bomb out? I wonder why it is building fine fo= r=20 > me. PowerPC (see above). It could also be some interaction with another tree in linux-next. > Anyway, I have added the include, as it is obviously correct(tm), thanks= =20 > for reporting it. Thanks. --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Thu__1_Apr_2010_18_35_30_+1100_Juv1ed00kvd2lyd9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAku0TMIACgkQjjKRsyhoI8wd7QCfQiPUx+A79YZhZosGZyuLUAN4 W7kAn2WuOr7CWIgwVdXCSeoNQHF66s17 =+M7A -----END PGP SIGNATURE----- --Signature=_Thu__1_Apr_2010_18_35_30_+1100_Juv1ed00kvd2lyd9-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/