From: Frans Pop <elendil@planet.nl>
To: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH] proc: Report file name on detected read_proc overflow
Date: Thu, 1 Apr 2010 16:41:56 +0200
User-Agent: KMail/1.9.9
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       adobriyan@gmail.com, helight.xu@gmail.com, viro@zeniv.linux.org.uk
References: <4BB49B0E.8070306@siemens.com>
In-reply-To: <4BB49B0E.8070306@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201004011641.58462.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 974
Lines: 21

Jan Kiszka wrote:
> -                                      "proc_file_read: Apparent buffer overflow!\n");
> +                                      "proc_file_read: Apparent buffer "
> +                                      "overflow reading \"%s\"!\n",
> +                                      file->f_path.dentry->d_name.name);

I think it would be good to keep "overflow" on the first line as that
may be what people will grep the source for. And maybe use single quotes
around the file name. So:

+                                      "proc_file_read: Apparent buffer overflow "
+                                      "reading '%s'!\n",
+                                      file->f_path.dentry->d_name.name);

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/