Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757125Ab0DAQCF (ORCPT ); Thu, 1 Apr 2010 12:02:05 -0400 Received: from nlpi129.sbcis.sbc.com ([207.115.36.143]:54938 "EHLO nlpi129.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757114Ab0DAQB6 (ORCPT ); Thu, 1 Apr 2010 12:01:58 -0400 Date: Thu, 1 Apr 2010 10:57:10 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Benjamin Herrenschmidt cc: Matthew Wilcox , "H. Peter Anvin" , Yinghai Lu , Andrew Morton , Rabin Vincent , lkml , penberg@cs.helsinki.fi, linux-arch@vger.kernel.org Subject: Re: start_kernel(): bug: interrupts were enabled early In-Reply-To: <1270075013.7101.78.camel@pasglop> Message-ID: References: <20100325194100.GA2364@debian> <20100331134048.da4e35a7.akpm@linux-foundation.org> <4BB3B4DB.7040904@kernel.org> <20100331210145.GB32165@parisc-linux.org> <4BB3B8FC.1020608@zytor.com> <20100331211754.GC32165@parisc-linux.org> <1270075013.7101.78.camel@pasglop> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 23 On Thu, 1 Apr 2010, Benjamin Herrenschmidt wrote: > On Wed, 2010-03-31 at 16:42 -0500, Christoph Lameter wrote: > > > > Do not run the checks while we are in a single threaded context? > > > > I thought we had some dynamic code patching thingamy that could change > > those when we go to smp mode? > > The problem isn't about checks. Those -will- enable IRQs before it's > safe to do so, the checks are perfectly right to point it out, it -is- a > bug waiting to happen on some random HW. Taking sems in single threaded mode is pretty pointless. Those functions could just return success until the scheduler is actually able to do something with threads. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/