Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777Ab0DAR3J (ORCPT ); Thu, 1 Apr 2010 13:29:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35123 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794Ab0DAR26 (ORCPT ); Thu, 1 Apr 2010 13:28:58 -0400 Date: Thu, 1 Apr 2010 10:24:29 -0700 (PDT) From: Linus Torvalds To: Alex Deucher cc: "Rafael J. Wysocki" , Linux PCI , Greg KH , Clemens Ladisch , Linux Kernel Mailing List , Jesse Barnes , Alex Deucher , dri-devel@lists.sourceforge.net, stable@kernel.org Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) In-Reply-To: Message-ID: References: <201003302316.45651.rjw@sisk.pl> <201004010313.32920.rjw@sisk.pl> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 24 On Thu, 1 Apr 2010, Alex Deucher wrote: > > Clemems' "PCI quirk: RS780/RS880: disable MSI completely" patch is the > right approach I think. Note that it's only devices hung off the int > gfx pci to pci bridge that have broken MSI (gfx and audio). MSI works > fine on the PCIE slots. I have a similar patch for rs400 chips on bug > 15626: > https://bugzilla.kernel.org/show_bug.cgi?id=15626 Hmm. Does 'pci_msi_enable' only cover regular PCI devices? Or will that pci_no_msi() quirk disable MSI for PCIE too? I think it will trigger for PCIE drivers too. Put another way: it sounds like the quirk now disables MSI for all devices. Maybe there would some more targeted mode? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/