Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758934Ab0DAUpv (ORCPT ); Thu, 1 Apr 2010 16:45:51 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:50369 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731Ab0DAUpq (ORCPT ); Thu, 1 Apr 2010 16:45:46 -0400 From: "Rafael J. Wysocki" To: Alex Deucher Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) Date: Thu, 1 Apr 2010 22:48:38 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc3-rjw; KDE/4.3.5; x86_64; ; ) Cc: Clemens Ladisch , Linus Torvalds , Linux PCI , Greg KH , Linux Kernel Mailing List , Jesse Barnes , dri-devel@lists.sourceforge.net, stable@kernel.org, Dave Airlie References: <201004012228.06938.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004012248.38794.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2253 Lines: 61 On Thursday 01 April 2010, Alex Deucher wrote: > On Thu, Apr 1, 2010 at 4:28 PM, Rafael J. Wysocki wrote: > > On Thursday 01 April 2010, Alex Deucher wrote: > >> On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch wrote: > >> > Alex Deucher wrote: > >> >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki wrote: > >> >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: > >> >>>> > PCI quirk: RS780/RS880: work around missing MSI initialization > >> >>>> > >> >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box > >> >>>> which happens to have a RS780. > >> > > >> > So it's better to disable MSI unconditionally. > >> > > >> > Rafael, can you check if MSI works for the HDMI audio device? > >> > (I'd guess it doesn't.) > >> > > >> >> I also have the attached patch queued in via Dave's tree to disable > >> >> MSI on all IGP chips for the time being. > >> > > >> > This disables MSI only for the graphics device. I'd prefer to have > >> > the quirk on its bridge so that MSI gets disabled for the HDMI audio > >> > device too, to avoid having to duplicate this quirk in the snd-hda-intel > >> > driver. > >> > > >> > ========== > >> > > >> > PCI quirk: RS780/RS880: disable MSI completely > >> > > >> > The missing initialization of the nb_cntl.strap_msi_enable does not seem > >> > to be the only problem that prevents MSI, so that quirk is not > >> > sufficient to enable MSI on all machines. To be safe, unconditionally > >> > disable MSI for the internal graphics and HDMI audio on these chipsets. > >> > > >> > Signed-off-by: Clemens Ladisch > >> > >> Works fine here. > >> > >> Tested-by: Alex Deucher > > > > Unfortunately it doesn't work for me without the > > > > if ((rdev->family >= CHIP_RV380) && > > (!(rdev->flags & RADEON_IS_IGP))) > > > > radeon quirk. > > what are your pci ids? 1022:960b I guess 1022 is AMD. OK, I'll try to add that. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/