Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757420Ab0DAWuZ (ORCPT ); Thu, 1 Apr 2010 18:50:25 -0400 Received: from outbound-mail-313.bluehost.com ([67.222.54.6]:42928 "HELO outbound-mail-313.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755012Ab0DAWuV (ORCPT ); Thu, 1 Apr 2010 18:50:21 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=XTYegc7fCyxr6lB9XM44Q+U4l+2zsGX3fjeGAS60nB9TC2TZkifrSWY+PmeP05P8bV02lob+Illu2d6a4bVG2HPWkll7eCeUntRQMVw9jG0kDCzhA9/aQJZD+rSalPhH; Date: Thu, 1 Apr 2010 15:48:47 -0700 From: Jesse Barnes To: Linus Torvalds Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Dave Airlie , dri-devel@lists.sourceforge.net, Linux PCI , Clemens Ladisch , Alex Deucher , stable@kernel.org, Greg KH Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) Message-ID: <20100401154847.20e9c8b8@jbarnes-piketon> In-Reply-To: References: <201003302316.45651.rjw@sisk.pl> <201004010313.32920.rjw@sisk.pl> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.110.194.140 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 38 On Thu, 1 Apr 2010 09:29:23 -0700 (PDT) Linus Torvalds wrote: > > > On Thu, 1 Apr 2010, Rafael J. Wysocki wrote: > > > > OK, I've verified that partial revert (below) is sufficient. > > Hmm. Through the DRM merge I just did, this area actually conflicted, and > the resolved version is now > > if ((rdev->family >= CHIP_RV380) && > (!(rdev->flags & RADEON_IS_IGP))) { > > which presumably also fixes your issue? > > [ Side note: somebody in the DRM tree seems to be way too used to LISP, > and thinks that adding parenthesis always improves the code ;-] > > However, I do suspect that we should probably revert the quirk regardless > as being useless (ie it probably was related to those IGP chips that > apparently don't do MSI anyway). > > So the patch that reverts the quirk by Clemens (to replace it with > disabling MSI entirely when the AMD NB doesn't accept them) seems to be a > good idea regardless, since it's apparently not just about gfx. Jesse? Yeah, that sounds fine. I can include it in my next pull req or you can just pick it up directly. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/