Message-ID: <4BB55968.3090105@cn.fujitsu.com>
Date: Fri, 02 Apr 2010 10:41:44 +0800
From: Li Zefan <lizf@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>
CC: rostedt@goodmis.org, Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>,
       "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
       James Bottomley <James.Bottomley@suse.de>,
       Ingo Molnar <mingo@redhat.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       "Martin K. Petersen" <martin.petersen@oracle.com>,
       Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>,
       lkml <linux-kernel@vger.kernel.org>,
       Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 1/2 v4] scsi: add __print_hex() to ftrace
References: <4BB4855E.7030509@jp.fujitsu.com>	 <4BB4864A.3060406@jp.fujitsu.com>	 <1270130265.19685.8933.camel@gandalf.stny.rr.com> <1270141412.1483.130.camel@Joe-Laptop.home>
In-Reply-To: <1270141412.1483.130.camel@Joe-Laptop.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 722
Lines: 23

Joe Perches wrote:
> On Thu, 2010-04-01 at 09:57 -0400, Steven Rostedt wrote:
>>> +const char *
>>> +ftrace_print_hex_seq(struct trace_seq *p, const unsigned char *buf, int buf_len)
>>> +{
>>> +	int i;
>>> +	const char *ret = p->buffer + p->len;
>>> +
>>> +	for (i = 0; i < buf_len; i++)
>>> +		trace_seq_printf(p, "%s%2.2x", i == 0 ? "" : " ", buf[i]);
>>> +
>>> +	trace_seq_putc(p, 0);
> 
> hex_dump_to_buffer?
> 

I've replied to you on this long ago, in v3 (or v2) patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/