Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758608Ab0DBKYb (ORCPT ); Fri, 2 Apr 2010 06:24:31 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:41168 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758311Ab0DBKYZ (ORCPT ); Fri, 2 Apr 2010 06:24:25 -0400 Date: Fri, 2 Apr 2010 11:24:22 +0100 From: Mark Brown To: Samuel Ortiz Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: Add WM8994 interrupt controller support Message-ID: <20100402102422.GA32467@rakim.wolfsonmicro.main> References: <1269894525-21530-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20100330141201.GA17007@sirena.org.uk> <20100402101754.GD8010@sortiz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100402101754.GD8010@sortiz.org> X-Cookie: WYSIWYG: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 25 On Fri, Apr 02, 2010 at 12:17:55PM +0200, Samuel Ortiz wrote: > Hi Mark, > > On Tue, Mar 30, 2010 at 03:12:02PM +0100, Mark Brown wrote: > > On Mon, Mar 29, 2010 at 09:28:45PM +0100, Mark Brown wrote: > > > > > + printk(KERN_CRIT "%x %x\n", status[0], status[1]); > > > > Clearly this is debug code and shouldn't be there in an actual version. > > I'll remove this when resubmitting after review & merge path are sorted > > out. > All right, I won't merge it for now. Did you see the question in the original posting about where this should be merged? The bulk of the code using these interrupts will be the CODEC driver for the device, but the CODEC driver needs to be able to check if interrupts are set up at all (since commonly CODECs don't have an IRQ line wired up) so it'd be nice if it were possible to merge via ASoC. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/