Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788Ab0DCABL (ORCPT ); Fri, 2 Apr 2010 20:01:11 -0400 Received: from sous-sol.org ([216.99.217.87]:53687 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751387Ab0DCABG (ORCPT ); Fri, 2 Apr 2010 20:01:06 -0400 Date: Fri, 2 Apr 2010 16:59:56 -0700 From: Chris Wright To: Joerg Roedel Cc: Chris Wright , Joerg Roedel , Neil Horman , Neil Horman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hbabu@us.ibm.com, iommu@lists.linux-foundation.org, "Eric W. Biederman" , Vivek Goyal Subject: Re: [PATCH 1/2] x86/amd-iommu: enable iommu before attaching devices Message-ID: <20100402235956.GD29241@sequoia.sous-sol.org> References: <20100331202745.GE13406@hmsreliant.think-freely.org> <20100401142902.GF24846@8bytes.org> <20100401144736.GA14069@shamino.rdu.redhat.com> <20100401155643.GG24846@8bytes.org> <20100401171149.GH13603@shamino.rdu.redhat.com> <20100401201433.GK24846@8bytes.org> <20100402000012.GA8930@hmsreliant.think-freely.org> <20100402003034.GX29241@sequoia.sous-sol.org> <20100402012353.GY29241@sequoia.sous-sol.org> <20100402091118.GM24846@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100402091118.GM24846@8bytes.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 14 * Joerg Roedel (joro@8bytes.org) wrote: > Ok, good to know this fixes the problem. One issue: If the > initialization of the domains fails the iommu hardware needs to be > disabled again in the free path. Sure, thanks for catching. Will resend shortly thanks, -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/