Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372Ab0DCB31 (ORCPT ); Fri, 2 Apr 2010 21:29:27 -0400 Received: from sous-sol.org ([216.99.217.87]:45705 "EHLO x200.localdomain" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755045Ab0DCB3C (ORCPT ); Fri, 2 Apr 2010 21:29:02 -0400 Message-Id: <20100403012820.229410717@sous-sol.org> User-Agent: quilt/0.47-1 Date: Fri, 02 Apr 2010 18:27:54 -0700 From: Chris Wright To: Joerg Roedel Cc: nhorman@tuxdriver.com, nhorman@redhat.com, vgoyal@redhat.com, hbabu@us.ibm.com, ebiederm@xmission.com, iommu@lists.linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] Revert "x86: disable IOMMUs on kernel crash" References: <20100403012751.834020949@sous-sol.org> Content-Disposition: inline; filename=crash-leave-iommu-enabled.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 42 This effectively reverts commit 61d047be99757fd9b0af900d7abce9a13a337488. Disabling the IOMMU can potetially allow DMA transactions to complete without being translated. Leave it enabled, and allow crash kernel to do the IOMMU reinitialization properly. Cc: Joerg Roedel Cc: Eric Biederman Cc: Neil Horman Cc: Vivek Goyal Signed-off-by: Chris Wright --- arch/x86/kernel/crash.c | 6 ------ 1 file changed, 6 deletions(-) --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -27,7 +27,6 @@ #include #include #include -#include #if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC) @@ -103,10 +102,5 @@ void native_machine_crash_shutdown(struc #ifdef CONFIG_HPET_TIMER hpet_disable(); #endif - -#ifdef CONFIG_X86_64 - x86_platform.iommu_shutdown(); -#endif - crash_save_cpu(regs, safe_smp_processor_id()); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/