Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755591Ab0DEQsH (ORCPT ); Mon, 5 Apr 2010 12:48:07 -0400 Received: from ns1.siteground211.com ([209.62.36.12]:45554 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180Ab0DEQr7 (ORCPT ); Mon, 5 Apr 2010 12:47:59 -0400 Date: Mon, 5 Apr 2010 19:48:39 +0300 From: Felipe Balbi To: kishore kadiyala Cc: Madhusudhan , Vimal Singh , tony@atomide.com, svenkatr@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko.lavinen@nokia.com Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance. Message-ID: <20100405164839.GB17388@gandalf> Reply-To: me@felipebalbi.com References: <35697.192.168.10.89.1265898023.squirrel@dbdmail.itg.ti.com> <004701caab40$68b576e0$544ff780@am.dhcp.ti.com> <003b01cad0f0$6ea78040$544ff780@am.dhcp.ti.com> <003c01cad1b1$da2cdbf0$544ff780@am.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground211.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - felipebalbi.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 30 Hi, On Mon, Apr 05, 2010 at 06:26:16PM +0530, kishore kadiyala wrote: > @@ -2091,9 +2091,9 @@ static int __init omap_hsmmc_probe(struct > mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | > MMC_CAP_WAIT_WHILE_BUSY; > > - if (mmc_slot(host).wires >= 8) > - mmc->caps |= MMC_CAP_8_BIT_DATA; > - else if (mmc_slot(host).wires >= 4) > + if (mmc_slot(host).wires == 8) > + mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA); > + else if (mmc_slot(host).wires == 4) > mmc->caps |= MMC_CAP_4_BIT_DATA; I believe it would be enough to just remove the 'else', so the code would look like: if (mmc_slot(host).wires >= 8) mmc->caps |= MMC_CAP_8_BIT_DATA; if (mmc_slot(host).wires >= 4) mmc->caps |= MMC_CAP_4_BIT_DATA; -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/