Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756291Ab0DETsS (ORCPT ); Mon, 5 Apr 2010 15:48:18 -0400 Received: from thunk.org ([69.25.196.29]:58821 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755608Ab0DETsM (ORCPT ); Mon, 5 Apr 2010 15:48:12 -0400 Date: Mon, 5 Apr 2010 15:48:03 -0400 From: tytso@mit.edu To: Jeff Moyer Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, esandeen@redhat.com Subject: Re: [patch/rft] jbd2: tag journal writes as metadata I/O Message-ID: <20100405194803.GC23670@thunk.org> Mail-Followup-To: tytso@mit.edu, Jeff Moyer , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, esandeen@redhat.com References: <20100405175205.GA4681@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 22 On Mon, Apr 05, 2010 at 02:36:07PM -0400, Jeff Moyer wrote: > > > > What benchmark were you using to test small file writes? This looks > > good to me as well, but we might want to do some extra benchmarking > > just to be sure we're not accidentally introducing a performance > > regression. > > iozone showed regressions for write and re-write in runs that include > fsync timings for small files (<8MB). Here's the command line used for > testing: > > iozone -az -n 4k -g 2048m -y 1k -q 1m -e iozone is showing performance regressions or performance improvements? I thought the point of this patch was to improve iozone benchmarks? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/