Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879Ab0DFIkM (ORCPT ); Tue, 6 Apr 2010 04:40:12 -0400 Received: from cantor.suse.de ([195.135.220.2]:43506 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157Ab0DFIkJ (ORCPT ); Tue, 6 Apr 2010 04:40:09 -0400 Date: Tue, 6 Apr 2010 10:40:06 +0200 (CEST) From: Jiri Kosina To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Andrew Morton , rvinyard@cs.nmsu.edu, =?ISO-8859-15?Q?Bruno_Pr=E9mont?= Subject: Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE In-Reply-To: <20100405220414.9d90da83.randy.dunlap@oracle.com> Message-ID: References: <201004052336.o35NaeSE015814@imap1.linux-foundation.org> <20100405220414.9d90da83.randy.dunlap@oracle.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 41 [ adding Bruno to CC ] On Mon, 5 Apr 2010, Randy Dunlap wrote: > From: Randy Dunlap > > HID_PICOLCD should depend on LCD_CLASS_DEVICE, otherwise the > build fails when HID_PICOLCD=y and LCD_CLASS_DEVICE=m: > > hid-picolcd.c:(.text+0x84523f): undefined reference to `lcd_device_unregister' > hid-picolcd.c:(.text+0x8478ab): undefined reference to `lcd_device_register' > hid-picolcd.c:(.text+0x84c15f): undefined reference to `lcd_device_unregister' > > Signed-off-by: Randy Dunlap > --- > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- mmotm-2010-0405-1609.orig/drivers/hid/Kconfig > +++ mmotm-2010-0405-1609/drivers/hid/Kconfig > @@ -265,6 +265,7 @@ config HID_PETALYNX > config HID_PICOLCD > tristate "PicoLCD (graphic version)" > depends on USB_HID > + depends on LCD_CLASS_DEVICE > select FB_DEFERRED_IO if FB > select FB_SYS_FILLRECT if FB > select FB_SYS_COPYAREA if FB Thanks Randy. We'll have to take care of the other dependencies as well though (CONFIG_LCD_CLASS_DEVICE, CONFIG_LEDS_CLASS). -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/