Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591Ab0DFJZo (ORCPT ); Tue, 6 Apr 2010 05:25:44 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:47782 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385Ab0DFJZi (ORCPT ); Tue, 6 Apr 2010 05:25:38 -0400 Date: Tue, 6 Apr 2010 11:25:23 +0200 From: Ingo Molnar To: Tejun Heo Cc: Linus Torvalds , lkml , Stephen Rothwell , Andrew Morton , Pekka Enberg , Christoph Lameter , Lee Schermerhorn , Alexey Dobriyan Subject: Re: [GIT PULL] break implicit percpu.h -> slab.h dependency Message-ID: <20100406092523.GA30270@elte.hu> References: <4BB95DEE.3050607@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BB95DEE.3050607@kernel.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 40 * Tejun Heo wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git slabh > > This is rather unusual pull request at this stage in -rc cycles but > given the mostly trivial nature and massive size of this change, I > think it would be beneficial to merge this while the tree isn't > changing too rapidly and as early as possible so that further > breakages aren't introduced. FYI, -tip testing found a build breakage with your changes: drivers/base/node.c:373: error: implicit declaration of function 'kmalloc' drivers/base/node.c:377: error: implicit declaration of function 'kfree' The fix is below. Since my first test today triggered a build failure i'd expect there to be more - i'll send all subsequent fixes to this thread. Thanks, Ingo Index: linux2/drivers/base/node.c =================================================================== --- linux2.orig/drivers/base/node.c +++ linux2/drivers/base/node.c @@ -16,6 +16,7 @@ #include #include #include +#include static struct sysdev_class_attribute *node_state_attrs[]; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/