Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757006Ab0DFQg4 (ORCPT ); Tue, 6 Apr 2010 12:36:56 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44938 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669Ab0DFQgt (ORCPT ); Tue, 6 Apr 2010 12:36:49 -0400 Date: Tue, 6 Apr 2010 09:32:43 -0700 (PDT) From: Linus Torvalds To: Minchan Kim cc: Rik van Riel , KOSAKI Motohiro , Borislav Petkov , Andrew Morton , Linux Kernel Mailing List , Lee Schermerhorn , Nick Piggin , Andrea Arcangeli , Hugh Dickins Subject: Re: Ugly rmap NULL ptr deref oopsie on hibernate (was Linux 2.6.34-rc3) In-Reply-To: <1270571019.1814.163.camel@barrios-desktop> Message-ID: References: <20100402175937.GA19690@liondog.tnic> <20100406173754.7E5A.A69D9226@jp.fujitsu.com> <4BBB475A.7070002@redhat.com> <1270568096.1814.145.camel@barrios-desktop> <1270571019.1814.163.camel@barrios-desktop> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 22 On Wed, 7 Apr 2010, Minchan Kim wrote: > > > > I don't think so. That isn't the racy case. We're working with a > > anon_vma_chain, so the anonvma is all there. > > But the anon_vma is using for another anon_vma. No, that can only happen if somebody has done "anon_vma_free()" on it. And nobody does that if the anonvma still has a non-empty'&anon_vma->head'. So as long as the anon_vma has a anon_vma_chain entry associated with it (or a ksm refcount, but that's a separate issue), it's not going to be re-allocated for any other use, because it's not going to be free'd. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/