Date: Tue, 6 Apr 2010 09:56:33 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Bruno =?ISO-8859-1?Q?Pr=E9mont?= <bonbons@linux-vserver.org>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-kernel@vger.kernel.org,
       linux-input@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       rvinyard@cs.nmsu.edu
Subject: Re: [PATCH mmotm] hid-picolcd: depends on LCD_CLASS_DEVICE
Message-Id: <20100406095633.49ec957a.randy.dunlap@oracle.com>
In-Reply-To: <20100406183535.7de3c628@neptune.home>
References: <201004052336.o35NaeSE015814@imap1.linux-foundation.org>
	<20100405220414.9d90da83.randy.dunlap@oracle.com>
	<alpine.LNX.2.00.1004061038510.8345@pobox.suse.cz>
	<20100406105635.5384a087@pluto.restena.lu>
	<20100406082614.79aaf1c5.randy.dunlap@oracle.com>
	<20100406183535.7de3c628@neptune.home>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2898
Lines: 97

On Tue, 6 Apr 2010 18:35:35 +0200 Bruno Pr?mont wrote:

> On Tue, 06 April 2010 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > On Tue, 6 Apr 2010 10:56:35 +0200 Bruno Pr?mont wrote:
> > 
> > > On Tue, 6 Apr 2010 10:40:06 +0200 Jiri Kosina <jkosina@suse.cz> wrote:
> > > > 
> > > > [ adding Bruno to CC ]
> > > > 
> > > > On Mon, 5 Apr 2010, Randy Dunlap wrote:
> > > > 
> > > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > > 
> > > > > HID_PICOLCD should depend on LCD_CLASS_DEVICE, otherwise the
> > > > > build fails when HID_PICOLCD=y and LCD_CLASS_DEVICE=m:
> > > > > 
> > > > > hid-picolcd.c:(.text+0x84523f): undefined reference to `lcd_device_unregister'
> > > > > hid-picolcd.c:(.text+0x8478ab): undefined reference to `lcd_device_register'
> > > > > hid-picolcd.c:(.text+0x84c15f): undefined reference to `lcd_device_unregister'
> > > 
> > > That is weird, the
> > > 
> > > #if defined(CONFIG_LCD_CLASS_DEVICE) || defined(CONFIG_LCD_CLASS_DEVICE_MODULE)
> > >   feature support code
> > > #else
> > >   empty stubs
> > > #endif
> > > 
> > > blocks should have prevented LCD_CLASS support from being built if it
> > > was not enabled in configuration.
> > > 
> > > Do you have the .config matching your build?
> > 
> > Yes, it's attached.
> 
> Thanks, here is the extract (only the pertinent items):
> CONFIG_BACKLIGHT_LCD_SUPPORT=y
> CONFIG_LCD_CLASS_DEVICE=m
> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> CONFIG_HID_PICOLCD=y
> 
> It triggers the issue by having PicoLCD built-in while one of the
> optional dependencies as a module.

Yes, basically what the patch description said.

> Any idea of how this can be solved with kbuild in order to keep the
> dependencies optional?
> 
> Something that would satisfy the following pseudocode:
>   if CONFIG_HID_PICOLCD == y
>     assert(CONFIG_LCD_CLASS_DEVICE != m)
> 

If you don't want the kconfig machinery to do that (it appears that you don't),
then I guess that you'll need to expand the source code to handle
CONFIG_LCD_CLASS_DEVICE=y and CONFIG_LCD_CLASS_DEVICE=m differently.
Or only handle them differently if HID_PICOLCD=y.  :(


> 
> One of my attempts did end up with a circular loop with regard to FB
> (some of the FB drivers did select INPUT)?

  (not that I can find)

CONFIG_VT does select INPUT
and CONFIG_DRM_I915 does
	select INPUT if ACPI


> I had something like:
> 
> config HID_PICOLCD
>   tristate ...
> 
> config HID_PICOLCD_FB
>   bool ...
>   depends on HID_PICOLCD
>   select FB
>   select FB_...
> 
> ...
> 
> Then in the code I checked for CONFIG_HID_PICOLCD_FB instead of
> (CONFIG_FB or CONFIG_FB_MODULE).


---
~Randy
(re)read Documentation/ManagementStyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/